Help! What's wrong with my code?

HelloWorld · #1 (**permalink**) 07-22-2007, 03:54 PM

Here's the code:

GradeBook.h

PHP Code:

  #include <iostream>;

#include <string>;

class GradeBook {
public:
    GradeBook(string); // constructor
    void setCourseName(string);
    string getCourseName();
    void displayMessage();
    void inputGrades();
    void displayGradeReport();
    int maximum(int, int, int);
private:
    string courseName;
    int maximumGrade;
}

Recursion.cpp (don't worry about the title, no connection with recursion)

PHP Code:

  #include "stdafx.h"

#include <iostream>;
using std::endl;
using std::cout;
using std::cin;

#include <string>;
using std::string;
using std::getline;

#include "GradeBook.h";

GradeBook::GradeBook(string name) {
    setCourseName(name);
    maximumGrade = 0;
}

void GradeBook::setCourseName(string name) {
    if (name.length() <= 25) {
        courseName = name;
    } else {
        courseName = name.substr(0, 25);
        cout << "Name \"" << name << "\" exceed maximum length of 25.\n"
            << "Only gets the first 25 characters";
    }
}

string GradeBook::getCourseName() {
    return courseName;
}

void GradeBook::displayMessage() {
    cout << "Welcome to " << getCourseName() << "!\n" << endl;
}

void GradeBook::inputGrades() {
    int grade1, grade2, grade3;
    cout << "Grade 1: ";
    cin >> grade1;
    cout << "Grade 2: ";
    cin >> grade2;
    cout << "Grade 3: ";
    cin >> grade3;

    maximumGrade = maximum(grade1, grade2, grade3);
}

int GradeBook::maximum(int x, int y, int z) {
    int max = x;
    if (y > max) {
        max = y;
    }
    if (z > max) {
        max = z;
    }

    return max;
}

void GradeBook::displayGradeReport() {
    cout << "Max grade: " << maximumGrade << endl;
}

int main() {
    GradeBook myGradeBook("C++ PROGRAMMING");
    myGradeBook.displayMessage();
    myGradeBook.inputGrades();
    myGradeBook.displayGradeReport();
    return 0;
}

They said that there's something wrong with the constructor, I have no clue why...

Bench · #2 (**permalink**) 07-22-2007, 04:28 PM

Firstly, there should be no semicolons in #include directives

Code:

#include <iostream>;

#include <string>;

Secondly, i'm not sure why you've limited your 'name' to 25 characters, since a string is able to hold as many as you need. (Although perhaps you have your reasons)

Lastly, you're missing a semicolon at the end of your class declaration

Code:

class GradeBook {
public:
    GradeBook(string); // constructor
    void setCourseName(string);
    string getCourseName();
    void displayMessage();
    void inputGrades();
    void displayGradeReport();
    int maximum(int, int, int);
private:
    string courseName;
    int maximumGrade;
} ;

The reason it gave you an error message about your constructor, is that you had written

Code:

#include "GradeBook.h"

on the line before your constructor's definition. The result of which, after the Preprocessor had glued your various #includes together, the compiler ended up thinking you intended your class, GradeBook (which was missing a semicolon), to be the return type of the constructor. Of course, constructors aren't allowed a return type, so the compiler threw up an error.

HelloWorld · #3 (**permalink**) 07-22-2007, 04:33 PM

DARN IT! I always forgot to put semi colon right after the class!!! OMG!!! I'm used with Java, that's why lol.. there's no semi colon after class XD

Thanx a lot Bench, it's fixed because of the semi colon. I need to get used with this.. For the string thing, I just want to try substr

BTW, I didn't remove the semi colon right on my include statement, and it seems that it ignores it...?

Lee · #4 (**permalink**) 07-22-2007, 04:38 PM

Quote:

Originally Posted by HelloWorld

BTW, I didn't remove the semi colon right on my include statement, and it seems that it ignores it...?

Maybe it is something to do with your compiler? It may see that includes closing arrow ">" and not compile anything on that line after that arrow.

Bench · #5 (**permalink**) 07-22-2007, 04:41 PM

Some compilers may ignore the semicolon after #include directives, however, its not in the standard, so some will throw up an error about it. (I've noticed that MSVC++ ignores semicolons here - I can only imagine the reason is for some MS language extension)

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

The Following User Says Thank You to Bench For This Useful Post:
HelloWorld (07-22-2007)