can somebody tell me why this code is not working

mikejkellyuk · #1 (**permalink**) 11-03-2007, 04:33 PM

hi can somebody tell me why this code is not working
thanks
mike

PHP Code:

  <?php
if (!$_POST) {
   //haven't seen the form, so show it
   $display_block = "
   <form method=\"post\" action=\"".$_SERVER["PHP_SELF"]."\">
   <p><strong>First/Last Names:</strong><br/>
   <input type=\"text\" name=\"f_name\" size=\"30\" maxlength=\"75\">
   <input type=\"text\" name=\"l_name\" size=\"30\" maxlength=\"75\"></p>

   <p><strong>Address:</strong><br/>
   <input type=\"text\" name=\"address\" size=\"30\"></p>

   <p><strong>City/State/PostCode:</strong><br/>
   <input type=\"text\" name=\"city\" size=\"30\" maxlength=\"50\">
   <input type=\"text\" name=\"state\" size=\"5\" maxlength=\"2\">
   <input type=\"text\" name=\"postcode\" size=\"10\" maxlength=\10"></p>

   <p><strong>Address Type:</strong><br/>
   <input type="radio\" name=\"add_type\" value=\"home\" checked> home
   <input type=\"radio\" name=\"add_type\" value=\"work\"> work
   <input type=\"radio\" name=\"add_type\" value=\"other\"> other</p>

   <p><strong>Telephone Number:</strong><br/>
   <input type=\"text\" name=\"tel_number\" size=\"30\" maxlength=\"25\">
   <input tupe=\"radio\" name=\"tel_type\" value=\"home\"checked> home
   <input type=\"radio\" name=\"tel_type\" value=\"work\"> work
   <inpur type=\"radio\" name=\"tel_type\" value=\"other\"> other</p>

   <p><strong>Fax Number:</strong><br/>
   <input type=\"text\" name=\"fax_number\" size=\"30\" maxlength=\"25\">
   <input type=\"radio\" name=\"fax_type\" value=\"home\"checked> home
   <input type=\"radio\" name=\"fax_type\" value=\"work\"> work
   <input type=\"radio\" name=\"fax_type\" value=\"other\"> other</p>

   <p><strong>Email Address:</strong><br/>
   <input type=\"text\" name=\"email\" size=\"30\" maxlength=\"25\">
   <input type=\"radio\" name=\"email_type\" value=\"home\"checked> home
   <input type=\"radio\" name=\"email_type\" value=\"work\"> work
   <input type=\"radio\" name=\"email_type\" value=\"other\"> other</p>

   <p><strong>Personal Notes:</strong><br/>
   <textarea name=\"note\" cols=\"35\" row=\"3\"
   wrap=\"virtual\"></textarea></p>

   <p><input type=\"submit\" name=\"submit\" value=\"Add Entry\"></p>
   </form>";

} else if ($_POST) {
   //time to add to tables, so check for required fields
   if (($_POST["f_name"] == "") || ($_POST["l_name"] == "")) {
       header("Location: addentry.php");
       exit;

    }

   //connect to database
   $mysqli = mysqli_connect("localhost", "root", "michael1", "addressbook");

  //add to master name table
  $add_master_sql = "INSERT INTO master_name (date_added, date_modified,
                     f_name, l_name) VALUES (now(), now(),
                     '".$_POST["f_name"]."', '".$_POST["l_name"]."')";
  $add_master_res = mysqli_query($mysqli, $add_master_sql)
                    or die(mysqli_error($mysqli));
  
  //get master_id for use with other tables
  $master_id = mysqli_insert_id($mysqli);

  if (($_POST["address"]) || ($_POST["city"]) || ($_POST["state"])
      || ($_PORT["postcode"])) {
      //something relevant so add to address table
     $add_address_sql = "INSERT INTO address (master_id, date_added,
                         date_modified, address, city, state, postcode,
                         type) VALUES ('".$master_id"', now(), now(),
                         '".$_POST["address"]."', '".$_POST["city"]."',
                         '".$_POST["state"]."', '".$_POST["postcode"]."',
                         '".$_POST["add_type"]."')";
  $add_address_res = mysqli_query($mysqli, $add_address_sql)
                     or die(mysqli_error($mysqli));

 }

  if ($_POST["tel_number"]) {
     //something relevant, so add to telephone table
     $add_fax_sql = "INSERT INTO fax (master_id, date_added,
                     date_modified, tel_number, type) VALUES
                     ('".$master_id."', now(), now(),
                     '".$_POST["tel_number"]."',
                     '".$_POST["tel_type"]."')";
     $add_tel_res = mysqli_query($mysqli, $add_tel_sql)
                    or die(mysqli_error($mysqli));

 }

  if ($_POST["fax_number"]) {
      //something relevant, so add to fax table
      $add_fax_sql = "INSERT INTO fax (master_id, date_added,
                      date_modified, fax_number, type) VALUES
                      ('".$master_id."', now(), now(),
                      '".$_POST["fax_number"]."',
                      '".$_POST["fax_type"]."')";
      $add_fax_res = mysqli_query($mysqli, $add_fax_sql)
                     or die(mysqli_error($mysqli));

 }
  
  if ($_POST["email"]) {
      //something relevant, so add to email table
      $add_email_sql = "INSERT INTO email (master_id, date_added,
                        date_modified, email, type) VALUES
                        ('".$master_id."', now(), now(),
                        '".$_POST["email"]."',
                        '".$_POST["email_type"]."')";
      $add_email_res = mysqli_query($mysqli, $add_email_sql)
                       or die(mysqli_error($mysqli));

 }

  if ($_POST["note"]) {
      //something relevant, so add to notes table
      $add_notes_sql = "INSERT INTO personal_notes (master_id, date_added,
                       date_modified, notes) VALUES ('".$master_id."',
                       now(), now(), '".$_POST["notes"]."')";
      $add_notes_res = mysqli_query($mysqli, $add_notes_sql)
                       or die(mysqli_error($mysqli));
 }
 mysqli_close($mysqli);
 $displayblock = "<p>Your entry has been added.
 would you like to <a href=\"addentry.php\">add another</a>?</p>;
}
?>
<html>
<head>
<title>Add an Entry</title>
</head>
<body>
<h1>Add an Entry</h1>
<php echo $display_block; ?>
</body>
</html>

HelloWorld · #2 (**permalink**) 11-03-2007, 11:44 PM

I suggest you to also post the error messages if there's any.. and I think there is for this one so that it's easier for us to look for the problems...

I'd say that the first line of code:

PHP Code:

  if (!$_POST) {

As far that I know $_POST is supposed to be $_POST['variable']

In addition, please read:
Markup For Easy Reading

TeraTask · #3 (**permalink**) 11-03-2007, 11:58 PM

Now that I've added in code tags, check where the color changes in an odd spot -- you'll notice some errors with escaping double quotes.

Also, you have $_PORT which will ultimately cause you problems.

Finally, you are not sanitizing your data, so your code is easily subject to SQL injection attacks!

HelloWorld:

What you mention is not an error, just not the best coding.

PHP Code:

  if (!$_POST) {

will function the same as

PHP Code:

  if (!empty($_POST)) {

HelloWorld · #4 (**permalink**) 11-04-2007, 12:17 AM

Moreover, I see that all of your mysql functions are called incorrectly...

PHP Code:

   mysqli_close($mysqli);

Suppose to be:

PHP Code:

   mysql_close($mysqli);

TeraTask · #5 (**permalink**) 11-04-2007, 12:21 AM

Not to be constantly contradicting you, HelloWorld, but that call is correct. The mysqli functions allow access to the "improved" functions for MySQL 5.x which are not available through simply calling mysql. See PHP: MySQL Improved Extension - Manual for more information.

HelloWorld · #6 (**permalink**) 11-04-2007, 01:09 AM

Thanx TeraTask, and I'm sorry for the poor advices..

TeraTask · #7 (**permalink**) 11-04-2007, 01:13 AM

Quote:

Originally Posted by HelloWorld

Thanx TeraTask, and I'm sorry for the poor advices..

No worries! You're still learning PHP anyway and for a noob, you do well.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

The Following User Says Thank You to TeraTask For This Useful Post:
HelloWorld (11-04-2007)